fix(ui): give the remaining pages a main landmark - #1591
Closed
culfin wants to merge 1 commit into
Closed
Conversation
Third and last follow-up to apache#1587. Nineteen routes hang straight off `pages/Layout` with no layout of their own — signing in, registering, recovering an account, confirming an address, and the error pages. They were the ones left without a landmark. `pages/Layout` itself is the wrong place for it: it wraps the header, so a `main` there would put the navigation inside the content region and "skip to content" would land before it. Instead, a pathless layout route that is nothing but a `main`. Three of them, one per stretch of such routes, so every path, guard and index stays exactly where it was — verified: 88 paths before, the same 88 after, no page removed. The diff looks larger than it is. Read with `git diff -w` it is 24 added lines in routes.ts; everything else is one indentation level. Checked by building the front end and stepping through the affected routes in a browser: /users/login, /users/register, /50x and an unknown path each render inside exactly one `main` and draw their content. (The console errors in that run come from the API being absent in a static build — `custom.css` is served by the Go side.) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Folded into #1587, which now covers every route rather than a third of them. Nothing is dropped; the commits are on that branch. Closing to keep the queue readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and last follow-up to #1587 (after #1589 for the admin area). Nineteen
routes hang straight off
pages/Layoutwith no layout of their own — signingin, registering, recovering an account, confirming an address, and the error
pages. They were the ones left without a landmark.
pages/Layoutitself is the wrong place to add one: it wraps the header, so amainthere would put the navigation inside the content region, and "skip tocontent" would land before it rather than after.
The change
A pathless layout route that is nothing but a
main:Three of them, one per stretch of such routes, so every path, guard and index
stays exactly where it was.
Verified structurally: 88 paths before, the same 88 after, no page removed,
three layout nodes added.
The diff looks larger than it is. Read with
git diff -w:24 added lines in the router — three eight-line wrappers. Everything else is
one indentation level.
Verified by running it
Built the front end and stepped through the affected routes in a browser:
<main>/users/login/users/register/50xThe console errors in that run come from the API being absent in a static
build —
custom.cssis served by the Go side, not by the bundle.With this, #1587, #1589 and this one together, every route of the interface
sits inside exactly one
main.🤖 Generated with Claude Code